Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report NGINX App Protect instances #942

Open
wants to merge 3 commits into
base: chore/add-nap-to-mock-collector
Choose a base branch
from
Open

Report NGINX App Protect instances #942

wants to merge 3 commits into from

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Dec 6, 2024

Proposed changes

Here is an example of a NGINX App Protect instance that is reported.

{
  instance_meta:{
    instance_id: "42f26e35-7b84-32d1-9ea9-343b5cbda9cb",
    instance_type: INSTANCE_TYPE_NGINX_APP_PROTECT,
    version: "5.144.0",
  },
  instance_config: {} 
  instance_runtime: {
    process_id: 4,
    nginx_app_protect_runtime_info: {
      release: "4.11.0",
      attack_signature_version: "2024.11.28",
      threat_campaign_version: "2024.12.02",
    },
  }
}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Dec 6, 2024
@dhurley dhurley self-assigned this Dec 6, 2024
@dhurley dhurley requested a review from a team as a code owner December 6, 2024 14:02
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Dec 6, 2024
oliveromahony
oliveromahony reviewed Dec 10, 2024
View reviewed changes
internal/watcher/instance/nginx_app_protect_process_parser.go
InstanceRuntime: &mpi.InstanceRuntime{
ProcessId: process.PID,
BinaryPath: process.Exe,
ConfigPath: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we populate this with the config location for NAP?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't sure how to get the config path for NAP so I left it blank for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@sean-breen sean-breen sean-breen approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees

@dhurley dhurley

Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhurley @oliveromahony @sean-breen @aphralG